Add infra pytest warnings plugin #2757
Open
+247
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchamarthi
requested review from
antonwolfy,
ndgrigorian and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Feb 6, 2026
antonwolfy
reviewed
Feb 6, 2026
antonwolfy
reviewed
Feb 9, 2026
dpnp/tests/infra_warning_utils.py
Outdated
Comment on lines
80
to
88
| os.makedirs(self.directory, exist_ok=True) | ||
| self._events_file = os.path.join(self.directory, self.events_artifact) | ||
| self._events_fp = open( | ||
| self._events_file, | ||
| "w", | ||
| encoding="utf-8", | ||
| buffering=1, | ||
| newline="\n", | ||
| ) |
Contributor
There was a problem hiding this comment.
It would be safe and clear to use from pathlib import Path and then:
Suggested change
| os.makedirs(self.directory, exist_ok=True) | |
| self._events_file = os.path.join(self.directory, self.events_artifact) | |
| self._events_fp = open( | |
| self._events_file, | |
| "w", | |
| encoding="utf-8", | |
| buffering=1, | |
| newline="\n", | |
| ) | |
| p = Path(self.directory).expanduser().resolve() | |
| if p.exists() and not p.is_dir(): | |
| raise ValueError(f"{p} exists and is not a directory") | |
| p.mkdir(parents=True, exist_ok=True) | |
| if Path(self.self.events_artifact).name != self.events_artifact: | |
| raise ValueError(f"Invalid filename (must not contain path parts): {self._events_file}") | |
| self._events_file = p / self.events_artifact | |
| self._events_fp = self._events_file.open(mode="w", encoding="utf-8", buffering=1, newline="\n") |
Author
There was a problem hiding this comment.
Good suggestion that works safe across platforms. I have adopted you suggestion.
Since this is a public recipe, my agenda here is to not raise error and break the workflow because of this plugin for what ever the reason. This would rather print and artifact wont be created.
vchamarthi
force-pushed
the
dpnp-warnings-plugin
branch
from
a337f4d to
b209cab
Compare
antonwolfy
reviewed
Feb 10, 2026
| except Exception as exc: | ||
| self._events_fp = None | ||
| self._events_file = None | ||
| self.directory = None |
Contributor
There was a problem hiding this comment.
It holds the env variable and it was set during the init. Why do we want to reset that here?
| EVENT_PREFIX = "DPNP_WARNING_EVENT - " | ||
|
|
||
| def __init__(self): | ||
| self.enabled = bool(warn_config.infra_warnings_enable) |
Contributor
There was a problem hiding this comment.
No need to cast, already holds a boolean value:
Suggested change
| self.enabled = bool(warn_config.infra_warnings_enable) | |
| self.enabled = warn_config.infra_warnings_enable |
Comment on lines
+217
to
+219
| except Exception: | ||
| pass | ||
| self._events_fp = None |
Contributor
There was a problem hiding this comment.
since we don't have any special exception handling:
Suggested change
| except Exception: | |
| pass | |
| self._events_fp = None | |
| finally: | |
| self._events_fp = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduce the plugin feature to capture and format pytest warnings to process it in internal CI.
These changes will not add any overhead to existing pytest scope. This feature can be fully enabled/disabled by env var -
DPNP_INFRA_WARNINGS_ENABLE